Re: [PATCH] xen block: remove driver_data direct access of struct device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 30, 2009 at 03:35:35PM -0700, Chris Wright wrote:
> * Greg Kroah-Hartman (gregkh@xxxxxxx) wrote:
> > In the near future, the driver core is going to not allow direct access
> > to the driver_data pointer in struct device.  Instead, the functions
> > dev_get_drvdata() and dev_set_drvdata() should be used.  These functions
> > have been around since the beginning, so are backwards compatible with
> > all older kernel versions.
> > 
> > Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> > Cc: virtualization@xxxxxxxxxxxxxx
> > Cc: Chris Wright <chrisw@xxxxxxxxxxxx>
> > Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> 
> Acked-by: Chris Wright <chrisw@xxxxxxxxxxxx>

Thanks, will add it.  Any objections for this to go through my
driver-core tree to Linus for 2.6.31?

> after...
> 
> > -		dev->dev.driver_data = NULL;
> > +		dev_det_drvdata(&dev->dev, NULL);
> 
> ...fixing your fingers/script so it compiles ;-)

Doh!

And here I thought I had built that one, I guess I hadn't, my mistake.
Thanks for catching that, I've now fixed it.

greg k-h
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization

[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux