Matthew Wilcox wrote: > On Sat, Sep 27, 2008 at 04:28:45PM +0800, Zhao, Yu wrote: >> +To register SR-IOV service, Physical Function device driver needs to call: >> + int pci_iov_register(struct pci_dev *dev, >> + int (*notify)(struct pci_dev *, u32), char **entries) > > I think a better interface would put the 'notify' into the struct > pci_driver. That would make 'notify' a bad name .... how about > 'virtual'? There's also no documentation for the second parameter to > 'notify'. Yes, putting the callback function to the 'pci_driver' is better. Looks like the 'virtual' is not very descriptive (and it's a adj. while other callbacks are verb). Any other candidates? Thanks, Yu _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
