On Thu, 06 Nov 2008 10:30:25 -0500
vgoyal@xxxxxxxxxx wrote:
>
> o Core IO controller implementation
>
> Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
>
2 comments after a quick look.
- I don't recommend generic work queue. More stacked dependency between "work"
is not good. (I think disk-driver uses "work" for their jobs.)
- It seems this bio-cgroup can queue the bio to infinite. Then, a process can submit
io unitl cause OOM.
(IIUC, Dirty bit of the page is cleared at submitting I/O.
Then dirty_ratio can't help us.)
please add "wait for congestion by sleeping" code in bio-cgroup.
Thanks,
-Kame
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization
