Jeremy Fitzhardinge wrote: > Hidetoshi Seto wrote: >> +#ifdef CONFIG_STOP_MACHINE >> +extern unsigned long stopmachine_timeout; >> +#endif > > No externs in C files. Put it in an appropriate header. sysctl.c already has many externs... but I can fix at least the above. > I'll do a proper review soon. Is it better to postpone v4 until your comment comes? Thanks, H.Seto _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization