On Tue, 2008-07-15 at 11:51 -0700, Suresh Siddha wrote: > On Tue, Jul 15, 2008 at 11:38:50AM -0700, Zachary Amsden wrote: > > > > Nacked-by: Zachary Amsden <zach@xxxxxxxxxx> > > > > What are you doing here and why aren't you cc-ing the maintainers? > > Sorry. I was about to bring you into the loop. > > Yinghai posted 32bit native apic_ops(similar to my 64bit apic ops patch, which > is different from pv_apic_ops) which is in tip/x86/x2apic and proposed a fix > for VMI case aswell. > > Based on my understanding, tip/x86/x2apic git commit > 94a8c3c2437c8946f1b6c8e0b2c560a7db8ed3c6 is wrong and it should be fixed with > something like > http://marc.info/?l=linux-kernel&m=121614328831237&w=2 Looks better, but I need to read more context to find out where the apic_ops variable comes from; I'll read the list for patches. You are correct in that we will want to use the same wait_icr_idle routine as native hardware; it's not clear from just this patch how that happens. Also, the VMI operations are sensitive to parameter order because they interface with an ABI at the other end. I need to check the parameter order for apic read / write is still consistent with the ABI. Zach _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
