On Mon, Jul 14, 2008 at 10:41:38PM -0500, Rusty Russell wrote: > > + /* If we can receive ANY GSO packets, we must allocate large ones. */ > + if (virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO4) > + || virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO6) > + || virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_ECN)) > + dev->features |= NETIF_F_LRO; We don't want to do this because LRO implies joining packets together in an irreversible way which is not what this is about. Case in point we're now disabling LRO for devices that are forwarding packets which is totally unnecessary for virtio. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
