On Wednesday 02 July 2008 15:13:59 Max Krasnyansky wrote:
> Rusty Russell wrote:
> > Add a IFF_VNET_HDR flag. This uses the same ABI as virtio_net (ie.
> > prepending struct virtio_net_hdr to packets) to indicate GSO and checksum
> > information.
> >
> > Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> > ---
> > drivers/net/tun.c | 90
> > ++++++++++++++++++++++++++++++++++++++++++++++++- include/linux/if_tun.h
> > | 2 +
> > 2 files changed, 91 insertions(+), 1 deletion(-)
> >
> > diff -r d94590c1550a drivers/net/tun.c
> > --- a/drivers/net/tun.c Thu Jun 26 00:21:11 2008 +1000
> > +++ b/drivers/net/tun.c Thu Jun 26 00:21:59 2008 +1000
> > @@ -63,6 +63,7 @@
> > #include <linux/if_tun.h>
> > #include <linux/crc32.h>
> > #include <linux/nsproxy.h>
> > +#include <linux/virtio_net.h>
> > #include <net/net_namespace.h>
> > #include <net/netns/generic.h>
> >
> > @@ -283,12 +284,24 @@ static __inline__ ssize_t tun_get_user(s
> > struct tun_pi pi = { 0, __constant_htons(ETH_P_IP) };
> > struct sk_buff *skb;
> > size_t len = count, align = 0;
> > + struct virtio_net_hdr gso = { 0 };
> >
> > if (!(tun->flags & TUN_NO_PI)) {
> > if ((len -= sizeof(pi)) > count)
> > return -EINVAL;
> >
> > if(memcpy_fromiovec((void *)&pi, iv, sizeof(pi)))
> > + return -EFAULT;
> > + }
> > +
> > + if (tun->flags & TUN_VNET_HDR) {
> > + if ((len -= sizeof(gso)) > count)
> > + return -EINVAL;
> > +
> > + if (gso.hdr_len > len)
> > + return -EINVAL;
> > +
> > + if (memcpy_fromiovec((void *)&gso, iv, sizeof(gso)))
> > return -EFAULT;
> > }
>
> Unless I'm missing something the 'if (gso.hdr_len > len)' must be after
> memcpy_fromiovec().
Yes, this was fixed in a followup... there was another bug picked up by markmc
too in this patch.
> > + case VIRTIO_NET_HDR_GSO_TCPV6:
> > + skb_shinfo(skb)->gso_type = SKB_GSO_TCPV6;
> > + break;
> > + default:
> > + tun->dev->stats.rx_dropped++;
> > + kfree_skb(skb);
> > + return -EINVAL;
> > + }
>
> We should use stats.rx_frame_errors instead of stats.rx_dropped to
> indicated that we dropped it because something was wrong with the framing
> (headers, etc). Applies to both of the cases above.
OK, done (all three). Will repost.
Thanks,
Rusty.
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization
