On Mon, Jun 16, 2008 at 02:41:41PM +1000, Rusty Russell wrote: > From: Mark McLoughlin <markmc@xxxxxxxxxx> > > hdr->csum_start is the offset from the start of the ethernet > header to the transport layer checksum field. skb->csum_start > is the offset from skb->head. > > skb_partial_csum_set() assumes that skb->data points to the > ethernet header - i.e. it computes skb->csum_start by adding > the headroom to hdr->csum_start. > > Since eth_type_trans() skb_pull()s the ethernet header, > skb_partial_csum_set() should be called before > eth_type_trans(). > > (Without this patch, GSO packets from a guest to the world outside the > host are corrupted). Is this in Linus's tree already? If so, what is the commit id. If not, we need a good reason to be able to take it into the -stable tree (note that 2.6.24 isn't being maintained anymore...) thanks, greg k-h _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
