Jeremy Fitzhardinge wrote: > Hm? I sent a reply, didn't I? Attached again. Hmm, seems to have gotten lost somewhere, I can't remember having seen that one. Lossy email sucks :-( >> Hmm, what is the state of include/xen/interface/? It is a straight copy >> of the xen public header files, right? Is it really ok to modify them? >> > > Yeah, sure. They were copied once, but they can now drift without > consequence. Xen defines an ABI, so it doesn't matter how the source > spells the names of the structures. Ok, so I'll go just doing that ;) >>> This comment is confusing. Are you explaining why the tsc is read >>> within the loop? I think it can be clarified. >>> >> This was just copyed over from somewhere else (kvmclock I think). >> > > OK, but it still needs to be clarified. Yep, will do. > Also, the patches themselves need some changelogs. Even though they're > mostly just code motion, it would be good if the changelog for the > common pvclock code had a description of the basics of operation. > > Also, one implicit part of the ABI which should be explicitly documented > is that the interface expects that the host updates the per-vcpu time > structures on the same physical CPU that the guest runs, and that's why > we can avoid explicit cross-cpu ordering barriers. pvclock.h is probably a good place for the structs and the comments ... cheers, Gerd -- http://kraxel.fedorapeople.org/xenner/ _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
