On Mon, 2008-05-26 at 17:48 +1000, Rusty Russell wrote: > Because we cache the last failed-to-xmit packet, if there are no > packets queued behind that one we may never send it (reproduced here > as TCP stalls, "cured" by an outgoing ping). ... > diff -r 1d1ff03de434 drivers/net/virtio_net.c > --- a/drivers/net/virtio_net.c Mon May 26 11:03:26 2008 +1000 > +++ b/drivers/net/virtio_net.c Mon May 26 16:37:20 2008 +1000 ... > @@ -432,6 +452,8 @@ static int virtnet_probe(struct virtio_d > skb_queue_head_init(&vi->recv); > skb_queue_head_init(&vi->send); > > + tasklet_init(&vi->tasklet, xmit_tasklet, (unsigned long)vi); > + > err = register_netdev(dev); Missing a tasklet_kill() in virtnet_remove() ? Cheers, Mark. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
