On Thursday 22 May 2008 21:35:19 Jens Axboe wrote: > On Thu, May 22 2008, Rusty Russell wrote: > > Thanks Chris, it seems reasonable and I'm sure it works (kinda hard to > > test here, it's my root block dev). Other drivers seem to do > > blk_cleanup_queue() *after* del_gendisk: does it matter? > > > > Jens CC'd: he's gentle with my dumb questions... Rusty. > > del_gendisk() can generate IO, so it would seem safer to do that > _before_ putting the queue reference :-) Thanks Jens. Chris, I've fixed that up here. Cheers, Rusty. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization