> Make NR_IRQ overridable by each pv instances. > Pv instance may need each own number of irqs so that > NR_IRQS should be the maximum number of nr_irqs each > pv instances need. This really looks dodgy. +#ifdef CONFIG_PARAVIRT + +/* Determine the maximal NR_IRQ which each pv instances require. + * i.e. NR_IRQS = max(IA64_NATIVE_NR_IRQS, XEN_NR_IRQS, ...) + */ + +#define NR_IRQS 1 + +#if IA64_NATIVE_NR_IRQS > NR_IRQS +#undef NR_IRQS +#define NR_IRQS IA64_NATIVE_NR_IRQS +#endif + +#ifdef CONFIG_XEN +#include <asm/xen/irq.h> +#if XEN_NR_IRQS > NR_IRQS +#undef NR_IRQS +#define NR_IRQS XEN_NR_IRQS +#endif +#endif /* CONFIG_XEN */ I don't see why Xen needs special casing here, it really makes the code gross. Please use one typedef for this, like PARAVIRT_NR_IRQS or something like that, so we don't end up with a KVM special case, an LGUEST special case and a Xen special case. Cheers, Jes _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
