Re: [PATCH 07/12] Xen: Make events.c portable for ia64/xen support.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Isaku Yamahata wrote:
> +/* macro to avoid header inclusion dependncy hell */
> +#define xen_irqs_disabled(regs)	(!((regs)->flags & X86_EFLAGS_IF))
>   

This seems pretty generic.  Is there no suitable existing function?  
Could irqs_disabled_flags() be pressed into service?  I guess it depends 
on how ia64 (and other architectures) can get the saved flags state from 
the interrupt context.

> +
> +/* macro to avoid header inclusion dependncy hell */
> +#define xen_do_IRQ(irq, regs)			\
> +	do {					\
> +		(regs)->orig_ax = ~(irq);	\
> +		do_IRQ(regs);			\
> +	} while (0)
>   

It's not possible to put this somewhere it could be an inline function?  
It might be better to make it an out of line function then.

    J
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization

[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux