Hi Christian,
Christian Borntraeger wrote:
struct vring_used
{
__u16 flags;
__u16 idx;
+ __u32 padding;
struct vring_used_elem ring[];
-};
+} __attribute__ ((packed));
This padding that you've put in is not something that would normally
occur on x86. I've checked with GCC on 32-bit and 64-bit and neither
would include that padding. Is that padding included on s390?
I don't think we can do this on x86 at this point as it changes the
ABI. FWIW, I agree with Arnd also that we should not explicitly pad
structures that are naturally aligned anyway.
Regards,
Anthony Liguori
struct vring {
unsigned int num;
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-devel mailing list
kvm-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/kvm-devel
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization
