Re: [PATCH] Use PCI revision field to indicate virtio PCI ABI version

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Rusty Russell wrote:
On Tuesday 29 January 2008 19:03:26 Avi Kivity wrote:
Rusty Russell wrote:
On Tuesday 29 January 2008 02:59:59 Anthony Liguori wrote:
As Avi pointed out, as we continue to massage the virtio PCI ABI, we can
make things a little more friendly to users by utilizing the PCI
revision field to indicate which version of the ABI we're using.  This
is a hard ABI version and incrementing it will cause the guest driver to
break.

This is the necessary changes to virtio_pci to support this.

Signed-off-by: Anthony Liguori <aliguori@xxxxxxxxxx>
Applied, thanks.
But that's done at the wrong level.  Anthony agreed the revision ID
should indicate the device ABI, not just the virtio ABI.  If we move to
that level, bumping just one device rev id on the host will break all
devices on the guest.

OK, I'll drop it.

Please pull in the patch again.

It's dumb anyway, since we can just change the ID if we want to break drivers. Having multiple ways of doing something we don't want to do seems silly.

I considered that too but there's no point in burning through the device IDs. This is what PCI revision IDs are meant for so we might as well use them.

Regards,

Anthony Liguori

Cheers,
Rusty.

_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization

[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux