Re: [PATCH] Use PCI revision field to indicate virtio PCI ABI version

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Avi Kivity wrote:
Rusty Russell wrote:
On Tuesday 29 January 2008 02:59:59 Anthony Liguori wrote:
As Avi pointed out, as we continue to massage the virtio PCI ABI, we can make things a little more friendly to users by utilizing the PCI revision field to indicate which version of the ABI we're using. This is a hard ABI
version and incrementing it will cause the guest driver to break.

This is the necessary changes to virtio_pci to support this.

Signed-off-by: Anthony Liguori <aliguori@xxxxxxxxxx>

Applied, thanks.


But that's done at the wrong level. Anthony agreed the revision ID should indicate the device ABI, not just the virtio ABI. If we move to that level, bumping just one device rev id on the host will break all devices on the guest.

That's not what I was agreeing too. I don't want to plumb an ABI interface through virtio for each device. This is what I didn't like about having an ABI field in the first place. I'm thinking we should just drop both of these and instead just rely on feature bits.

Regards,

Anthony Liguori

_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization

[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux