On Wed, Jan 16, 2008 at 03:19:03PM +1100, Rusty Russell wrote: > > > It's far easier to deal with GSO if we don't have to parse the packet > > > to figure out the header length. Add the field to the virtio_net_hdr > > > struct (and fix the spaces that somehow crept in there). > > > Why do we need this? When receiving GSO packets from an untrusted > > source the network stack will fill in the transport header offset > > after verifying that the headers are sane. > > Thanks for clarifying; it simplifies things. Actually now that I've tried your test program I can see that this field exists not because of GSO, but because of SG. It tells you how many bytes you want to put in the skb head as opposed to the frag array. So this field is fine with me as long as it is named as such to avoid confusion since it really has nothing to do with GSO as you also need it for SG with large MTUs. I think this is more flexible than the Xen approach where this is essentially hard-coded to 64 bytes. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
