Anthony Liguori wrote:
BTW, I don't think the target should be a config value. You don't gain anything from it being in the config space and it's somewhat unnatural for a virtio device. It makes more sense as a message to the guest.
I disagree. The target is state, not an individual item that needs to be acted on. Having it as a single variable means that multiple changes are collapsed automatically, and that the the setting survives module reload.
It's like a volume control, it doesn't send messages when you turn it, it just sets a value.
(maybe a thermostat knob is a better analogy, with the driver being the circuitry around the knob that tries to control the temperature to match the setting)
I believe state-like controls will be useful for other settings, like ethernet link state.
-- error compiling committee.c: too many arguments to function _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
