Re: [PATCH 21/21] [PATCH] finish processor.h integration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Glauber de Oliveira Costa <gcosta@xxxxxxxxxx> wrote:

>> here the problem is apparently caused by your patch, a careless 
>> 'unification' of include file sections. 32-bit had this:
>
> Point is this patches do unification, but they are not just that, as 
> you can see. I am attempting to cleanup headers that appears not to be 
> used, [...]

do cleanups and unification in _separate_ patches. We do not want to 
change a SINGLE LINE OF SOURCE CODE in a patch that says "unify" and 
moves a block of code from one file to another, ok? If you see some 
obvious cleanups do it in pre or post patches (whichever looks more 
logical). That makes it totally bisectable and i can drop the bogus 
cleanup patch instead of having to drop a full unification patch.

	Ingo
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization

[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux