On Mon, Nov 19, 2007 at 11:20:15AM +1100, Rusty Russell wrote:
> skb is only NULL the first time around: it's more correct to test for
> being under-budget.
>
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
That looks better to me.
Acked-by: Simon Horman <horms@xxxxxxxxxxxx>
> diff -r 2a94425ac7d5 drivers/net/virtio_net.c
> --- a/drivers/net/virtio_net.c Thu Nov 15 13:47:28 2007 +1100
> +++ b/drivers/net/virtio_net.c Thu Nov 15 23:10:44 2007 +1100
> @@ -198,8 +198,8 @@ again:
> if (vi->num < vi->max / 2)
> try_fill_recv(vi);
>
> - /* All done? */
> - if (!skb) {
> + /* Out of packets? */
> + if (received < budget) {
> netif_rx_complete(vi->dev, napi);
> if (unlikely(!vi->rvq->vq_ops->restart(vi->rvq))
> && netif_rx_reschedule(vi->dev, napi))
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Horms
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization
