Re: [PATCH] Fix preemptible lazy mode bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Rusty Russell wrote:
>  static inline void arch_flush_lazy_mmu_mode(void)
>  {
> -	PVOP_VCALL1(set_lazy_mode, PARAVIRT_LAZY_FLUSH);
> +	if (unlikely(__get_cpu_var(paravirt_lazy_mode) == PARAVIRT_LAZY_MMU))
> +		arch_leave_lazy_mmu_mode();
>  }
>   

This changes the semantics a bit; previously "flush" would flush
anything pending but leave us in lazy mode.  This just drops lazymode
altogether?

I guess if we assume that flushing is a rare event then its OK, but I
think the name's a bit misleading.  How does it differ from plain
arch_leave_lazy_mmu_mode()?

    J
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization

[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux