On Tue, 2007-08-21 at 17:06 +0200, Arnd Bergmann wrote: > On Tuesday 21 August 2007, Rusty Russell wrote: > > > One solution would be to use the xmit_done interrupt. Unfortunately this would > > > require additional locking as multiple interrupts can happen at two or more > > > cpus. Do you have any better ideas? > > > > The only reason that we don't do it in skb_xmit_done() is because > > kfree_skb() isn't supposed to be called from an interrupt. But there's > > dev_kfree_skb_any() which can be used. > > That will simply trigger a softirq, right? If you need the softirq anyway, > why not do all the tx handling in the poll() method like other drivers? That would work, too. It seems a little non-obvious to me to trigger poll when a packet has been transmitted, but if that's the Standard I'll follow. Cheers, Rusty. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
