Zachary Amsden wrote:
Well, I think they are pretty good, but for the init group of ops, it
seems it would be clearer conceptually to group pagetable setup with
the MMU hooks and time init with the time operations. Otherwise, the
init group gets very jumbled as we pull in new interfaces (APIC has
BSP and AP init functions, for example).
I tend to agree, but the main reason I grouped them is because they're
init code, and therefore need never be exported. Also, some are really
just used at boot time, and don't clearly fit into any other grouping.
I guess I could expand pv_misc_ops.
I think that is probably the best solution; splitting the patch code
to deal with individual structure seems awkward.
Yes.
The only downside is that moving an op between groups requires quite a
few places to be touched. At least its all compile-time checked.
J
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization
