> +static void do_virtblk_request(request_queue_t *q)
> +{
> + struct virtio_blk *vblk = NULL;
> + struct request *req;
> + struct virtblk_req *vbr;
> +
> + while ((req = elv_next_request(q)) != NULL) {
> + vblk = req->rq_disk->private_data;
> +
> + vbr = mempool_alloc(vblk->pool, GFP_ATOMIC);
> + if (!vbr)
> + goto stop;
> +
> + BUG_ON(req->nr_phys_segments > ARRAY_SIZE(vblk->sg));
> + vbr->req = req;
> + if (!do_req(q, vblk, vbr))
> + goto stop;
> + blkdev_dequeue_request(req);
> + }
> +
> +sync:
> + if (vblk)
this check looks bogus, as vblk->pool has been accessed unconditionally above
> + vblk->vq->ops->sync(vblk->vq);
> + return;
> +
> +stop:
> + /* Queue full? Wait. */
> + blk_stop_queue(q);
> + mempool_free(vbr, vblk->pool);
> + goto sync;
> +}
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization
