Re: [PATCH 1/3] KVM paravirt_ops infrastructure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Andi Kleen <ak@xxxxxxx> wrote:

> 
> > > +       if (wrmsr_safe(MSR_KVM_API_MAGIC, __pa(para_state), 0)) {
> > > +               printk(KERN_INFO "KVM guest: WRMSR probe failed.\n");
> > > +               return -ENOENT;
> > > +       }
> > 
> > How about printk(KERN_INFO "I am not a KVM guest\n");?
> 
> Actually paravirt probes that fail should be silent; similar like 
> drivers that don't find their hardware should do the same. Otherwise 
> if there are later distro kernels with various of those compiled in 
> the boot log would become quite noisy

yeah. I suspect printing that it's executing in native mode is OK.

	Ingo
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization

[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux