Rusty Russell wrote:
Two versions, size *and* ret? This seems like overkill...
I think we ought to move away from version numbers and use feature availability flags instead.
+ if (rc) { + printk(KERN_INFO "paravirt KVM unavailable\n");Double-printk when KVM isn't detected seems overkill. Perhaps you could just fold this all into one function... (Personal gripe: I consider a variable named "rc" to be an admission of semantic defeat... "err" would be better here...)
I just use 'r' (short for 'argh'). -- error compiling committee.c: too many arguments to function _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
