On Wed, May 16, 2007 at 09:32:16AM +1000, Rusty Russell wrote: > On Tue, 2007-05-15 at 21:47 +1000, Stephen Rothwell wrote: > > On Tue, 15 May 2007 21:42:35 +1000 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > > > > > > On Tue, 15 May 2007 11:17:07 +1000 Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote: > > > > - on_each_cpu(adjust_pge, 0, 0, 1); > > > > + on_each_cpu(adjust_pge, (void *)0, 0, 1); > > > > > > Sorry? What ever happened to a simple NULL? > > > > Oh, I guess that is an explicit (numeric) 0 (of some type) caste to > > "void *" because of the prototype - rather than not passing anything? > > Indeed. We really want to pass a bool, but on_each_cpu uses a void *. > Hence the clearest solution seemed "(void *)0" and "(void *)1" in the > callers. Cleanest way to do that is to pass the value by reference. const int some_useful_name = 0; on_each_cpu(adjust_pge, &some_useful_name, 0, 1); _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
