On Sun, 2007-05-13 at 19:43 +0100, Al Viro wrote: > On Fri, May 11, 2007 at 11:21:30AM +1000, Rusty Russell wrote: > > /* Devices are in page above top of "normal" mem. */ > > - lguest_devices = ioremap(max_pfn << PAGE_SHIFT, PAGE_SIZE); > > + lguest_devices = (__force void*)ioremap(max_pfn<<PAGE_SHIFT,PAGE_SIZE); > > Er... What's being done here? What are we mapping and what's going to > be accessed when we dereference that sucker? This, too, is now wrapped in lguest_map() in the updated patch. Guest virtual device memory can be directly accessed, but Jeff Garzik and Christoph Hellwig made good points about not encouraging such abnormal use of ioremap in drivers. BTW, I've done a new rollup patch of lguest against 2.6.21, if you would like to review the whole thing. This version includes the big code documentation patch not yet in -mm. http://lguest.ozlabs.org/lguest-2.6.21-290.patch.gz Thanks, Rusty. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
