On Sun, 2007-05-13 at 19:47 +0100, Al Viro wrote: > On Sun, May 13, 2007 at 02:07:25PM +1000, Rusty Russell wrote: > > Most importantly, I now realize that Christoph's incorrect ranting > > about lgread_u32 et al was in fact a subtle ploy to make me diagnose > > the real issue: sparse 0.3 complains about casting a __user pointer > > to/from u32, but not an "unsigned long". They are (currently) > > equivalent for lguest, but this is a much better solution than __force. > > The real fix would be to declare it with u32 __user * as argument and deal > with callers. Hi Al. Arguments come in from the guest in registers. I could use a funky union in the structure definition, but I don't think we're winning anything at that point. Hope that clarifies, Rusty. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
