On Wed, 2007-05-09 at 13:16 +0300, Pekka Enberg wrote: > Hi Rusty, > > On 5/9/07, akpm@xxxxxxxxxxxxxxxxxxxx <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > +static void add_lguest_device(unsigned int index) > > +{ > > + struct lguest_device *new; > > + > > + lguest_devices[index].status |= LGUEST_DEVICE_S_ACKNOWLEDGE; > > + new = kmalloc(sizeof(struct lguest_device), GFP_KERNEL); > > + if (!new) { > > + printk(KERN_EMERG "Cannot allocate lguest device %u\n", index); > > + lguest_devices[index].status |= LGUEST_DEVICE_S_FAILED; > > [snip] > > Any reason why we don't return an error here? Hi Pekka, Hmm, where would the error go? A little confused, Rusty. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization