On Sun, 2007-04-29 at 09:11 -0600, Eric W. Biederman wrote: > Right now I'm a little frustrated that insanity below slipped into > head.S right after the 32bit entry point after the review said > use the normal linux parameters for parameter passing. > > > #ifdef CONFIG_PARAVIRT > > movl %cs, %eax > > testl $0x3, %eax > > jnz startup_paravirt > > #endif > > The whole thing should be based on a value in the linux parameter block > pointed to by %esi, instead of the insane preserve all registers and > attempt to be super compatible with everyone. Dammit, Eric, you spend a lot of time using words like "insane" where you mean we didn't do everything all at once. It's *not* clear that using %esi is sane, but nothing in the current code prevents that. I was trying to get Xen to use this entry point rather than their own: I failed, and only lguest now uses it. Fortunately, this also means it's trivial to change. Rusty. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
