On 10/04/07, Zachary Amsden <zach@xxxxxxxxxx> wrote:
> No, just no. You do not use goto to skip a code block. You do not
> return an obvious variable from a singly-inlined function and give
> the function a return value. You don't put unexplained comments
> about kmalloc in code which doesn't do dynamic allocation. And
> you don't leave stray warnings around for no good reason.
>
> Also, when possible, it is better to use block scoped variables
> because gcc can sometime generate better code.
>
> Signed-off-by: Zachary Amsden <zach@xxxxxxxxxx>
>
> diff -r ed741f57dae8 arch/i386/kernel/cpu/mcheck/p4.c
> --- a/arch/i386/kernel/cpu/mcheck/p4.c Fri Apr 06 14:29:52 2007 -0700
> +++ b/arch/i386/kernel/cpu/mcheck/p4.c Fri Apr 06 14:43:24 2007 -0700
[...]
> static fastcall void intel_machine_check(struct pt_regs * regs, long error_code)
> @@ -155,7 +146,6 @@ static fastcall void intel_machine_check
> u32 alow, ahigh, high, low;
> u32 mcgstl, mcgsth;
> int i;
> - struct intel_mce_extended_msrs dbg;
>
> rdmsr (MSR_IA32_MCG_STATUS, mcgstl, mcgsth);
> if (mcgstl & (1<<0)) /* Recoverable ? */
> @@ -164,7 +154,9 @@ static fastcall void intel_machine_check
> printk (KERN_EMERG "CPU %d: Machine Check Exception: %08x%08x\n",
> smp_processor_id(), mcgsth, mcgstl);
>
> - if (intel_get_extended_msrs(&dbg)) {
> + if (mce_num_extended_msrs > 0) {
> + struct intel_mce_extended_msrs dbg;
shouldn't there be a blank line here?
> + intel_get_extended_msrs(&dbg);
> printk (KERN_DEBUG "CPU %d: EIP: %08x EFLAGS: %08x\n",
> smp_processor_id(), dbg.eip, dbg.eflags);
> printk (KERN_DEBUG "\teax: %08x ebx: %08x ecx: %08x edx: %08x\n",
--
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization
