Andrew Morton wrote: > On Wed, 04 Apr 2007 12:12:09 -0700 Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote: > > >> Three cleanups: >> - change "instable" -> "unstable" >> - its better to use get_cpu_var for getting this cpu's variables >> - change cycles_2_ns to do the full computation rather than just the >> tsc->ns scaling. Its a simpler interface, and it makes the function >> more generally useful. >> >> Signed-off-by: Jeremy Fitzhardinge <jeremy@xxxxxxxxxxxxx> >> >> --- >> arch/i386/kernel/sched-clock.c | 35 +++++++++++++++++++++-------------- >> > > I'm dropping the relevant patch from Andi's tree due to it causing > mysterious hangs when initscripts start ondemand. So I'll need to drop > this patch and "[patch 19/20] Add a sched_clock paravirt_op". > > > I still need to work out why that hang is happening - it is very > mysterious. I got as far as working out that it was hanging on > write_seqlock_irqsave(xtime_lock), then remembered that it's with > CONFIG_SMP=n so I stomped off to bed in disgust. Later. > Though I do get: BUG: at arch/i386/kernel/sched-clock.c:167 init_sched_clock() [<c0109012>] show_trace_log_lvl+0x1a/0x30 [<c01095c7>] show_trace+0x12/0x14 [<c010965b>] dump_stack+0x16/0x18 [<c0465f51>] init_sched_clock+0x82/0xa8 [<c045e547>] init+0x14b/0x241 [<c0108bf7>] kernel_thread_helper+0x7/0x10 ======================= which suggests that its being initialized too late. J _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization