On Wed, 2007-04-04 at 15:07 -0400, Steven Rostedt wrote: > [Bug that was found by my previous patch] > > This patch allows things like modules, which don't have a direct > __pa(EIP) mapping to do emulated instructions. > > Sure, the emulated instruction probably should be a paravirt_op, but > this patch lets you at least boot a kernel that has modules needing > emulated instructions. Yeah, I haven't tried loading random modules but I can imagine this does happen (what module was it, BTW?) I used to have a function just like this, but managed to get rid of it. Hmm, perhaps we should have an "int lgread_virt_byte(u8 *)" which does the pgtable walk and read all in one? It won't be efficient, but it'll be more correct and maybe even fewer lines 8) Thanks for the patch! Rusty. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
