On Tue, Mar 13, 2007 at 04:30:45PM -0700, Jeremy Fitzhardinge wrote: > [ brcl, mingo: Would you mind having a close look at the code in > xen_exit_mm and drop_mm_ref? - Thanks ] I see what you're doing here, and this comment seems to allude to the reasons behind it without spelling it out. > +/* > + * We aggressively remove defunct pgd from cr3. We execute unmap_vmas() > + * *much* faster this way. > + */ Are you switching mms in order to avoid all of the overhead associated with flushing an active mm during task exit? If so, it makes much more sense to do this in the generic helper, as it should be a win on x86 and x86-64 where switching to init_mm is relatively low cost given the support for global pages. I'll run some tests on a couple of systems this evening and post the results. -ben -- "Time is of no importance, Mr. President, only life is important." Don't Email: <zyntrop@xxxxxxxxx>. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxx https://lists.osdl.org/mailman/listinfo/virtualization
