On Wed, 2007-02-28 at 09:32 +0100, Ingo Molnar wrote: > * Jeremy Fitzhardinge <jeremy at goop.org> wrote: > > > >> +#ifdef CONFIG_PARAVIRT > > >> +/* After pte_t, etc, have been defined */ > > >> +#include <asm/paravirt.h> > > >> +#endif > > >> > > > > > > hm - there's already a CONFIG_PARAVIRT conditional in > > > asm-i386/paravirt.h. > > > > Yes, but it happens after asm/paravirt.h has already included some > > things, and it ends up causing problems. paravirt.h still defines > > various stub functions in the !CONFIG_PARAVIRT case, so it needs to do > > the includes either way. > > hm, it then needs to be fixed first, instead of adding to the mess. Yes, originally paravirt.h didn't define anything if !CONFIG_PARAVIRT for this reason: getting it tied into the other headers correctly is a PITA. Rusty.
