On Sun, 2007-02-25 at 16:51 -0800, Jeremy Fitzhardinge wrote: > Rusty Russell wrote: > > Yes, the combo was *so* common we went for one patch site rather than > > two. > > > > Is there any disadvantage to having two adjacent patch sites? For > native the same instruction sequence will be generated, but with a few > more nops. Originally it was just 24 bytes vs 12 bytes, it's probably less now. But as I said, it's *really* popular. I don't have the numbers on me, but it's almost worth making it the default and implementing cli / sti in terms of save & restore 8) Rusty.