On Sat, 10 Feb 2007, Rusty Russell wrote: > +/* 64k ought to be enough for anybody! */ > +#define HYPERVISOR_MAP_ORDER 16 > +#define HYPERVISOR_PAGES ((1 << HYPERVISOR_MAP_ORDER)/PAGE_SIZE) I think it'd be better to go back to defining HYPERVISOR_SIZE then derive the map order from that via get_order(), as it should be 4 instead of 16; and this code is now both implying PAGE_SIZE while also using it for calculations. - James -- James Morris <jmorris at namei.org>
