On Fri, Feb 09, 2007 at 11:39:31PM +1100, Rusty Russell wrote: > On Fri, 2007-02-09 at 11:09 +0100, Andi Kleen wrote: > > On Friday 09 February 2007 10:20, Rusty Russell wrote: > > > Unfortunately, we don't have the build infrastructure for "private" > > > asm-offsets.h files, so there's a not-so-neat include in > > > arch/i386/kernel/asm-offsets.c. > > > > Ask the kbuild people to fix that? > > > > It indeed looks ugly. > > > > I bet Xen et.al. could make good use of that too. > > Yes. I originally had the constants #defined in the header and a whole > heap of BUILD_BUG_ON(XYZ_offset != offsetof(xyz)) in my module, which > was even uglier (but at least contained in my code). I do not quite see what you ask for. Care to try to describe the problem a bit then I may look at it sometime. [Heading for vacation in a few hours so no prompt reply] Sam
