On Sat, Jan 13, 2007 at 05:07:28PM -0800, Arjan van de Ven wrote: > > + > > +#define DPRINTK(_f, _a...) pr_debug(_f, ## _a) > > why this silly abstraction? Just use pr_debug in the code directly Actually, for drivers, like this one, you should use the dev_printk() and friends (dev_dbg, dev_err, etc.) instead so that userspace knows exactly which device and driver the message comes from. thanks, greg k-h