On Wed, 2006-11-01 at 15:31 -0800, Andrew Morton wrote: > On Wed, 01 Nov 2006 21:32:30 +1100 > Rusty Russell <rusty at rustcorp.com.au> wrote: > > > +static __inline void apic_write(unsigned long reg, unsigned long v) > > +static __inline void apic_write_atomic(unsigned long reg, unsigned long v) > > +static __inline unsigned long apic_read(unsigned long reg) > > Just `inline', please. akpm says: "Just `inline', please." Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> diff -r 3a3bc9aed04c include/asm-i386/paravirt.h --- a/include/asm-i386/paravirt.h Thu Nov 02 11:42:22 2006 +1100 +++ b/include/asm-i386/paravirt.h Thu Nov 02 11:44:15 2006 +1100 @@ -304,17 +304,17 @@ static inline void slow_down_io(void) { /* * Basic functions accessing APICs. */ -static __inline void apic_write(unsigned long reg, unsigned long v) +static inline void apic_write(unsigned long reg, unsigned long v) { paravirt_ops.apic_write(reg,v); } -static __inline void apic_write_atomic(unsigned long reg, unsigned long v) +static inline void apic_write_atomic(unsigned long reg, unsigned long v) { paravirt_ops.apic_write_atomic(reg,v); } -static __inline unsigned long apic_read(unsigned long reg) +static inline unsigned long apic_read(unsigned long reg) { return paravirt_ops.apic_read(reg); }