On Wed, 2006-11-01 at 15:29 -0800, Andrew Morton wrote: > On Wed, 01 Nov 2006 21:30:43 +1100 > Rusty Russell <rusty at rustcorp.com.au> wrote: > > > --- a/include/asm-i386/bugs.h > > +++ b/include/asm-i386/bugs.h > > @@ -21,6 +21,7 @@ > > #include <asm/processor.h> > > #include <asm/i387.h> > > #include <asm/msr.h> > > +#include <asm/paravirt.h> > > In many other places you have > > #ifdef CONFIG_PARAVIRT > #include <asm/paravirt.h> > ... > > But not here. > > Making <asm/paravirt.h> invulnerable would be the more typical approach. It *is* actually safe. The "#ifdef CONFIG_PARAVIRT / #include <asm/paravirt.h> / #else / <... native versions...>" is to give a big hint to the reader to look in paravirt.h for the real definitions. Originally I had a noparavirt.h where all these lived, and people hated it. So we did it this way, which minimizes churn. Rusty.
