On Fri, 2006-09-01 at 18:05 +0200, Martin Schwidefsky wrote: > On Fri, 2006-09-01 at 08:56 -0700, Dave Hansen wrote: > > > This question did come up already. arch_free_page() is done before the > > > PageReserved() check so it isn't suitable for stable/unused state > > > transitions. You can argue that arch_free_page() should be moved but who > > > knows what the architecture defined function is supposed to do? > > > page_set_stable/page_set_unused on the other hand have a clearly defined > > > meaning. > > > > With a patch set this large, I think it would at least be a nice thing > > to go through and review the other architectures' uses. > > There is only one user right now: UML. Then it should be awfully easy to go figure out what they are doing and coordinate by using the same functions, right? ;) -- Dave