On Tue, 2006-08-22 at 11:06 +0200, Andi Kleen wrote: > On Tue, 22 Aug 2006 15:55:15 +1000 > Rusty Russell <rusty at rustcorp.com.au> wrote: > > > OK, this is the revised paravirt.h (Andi has seen this before), then the > > second is the binary patching stuff. More things get added to the > > paravirt struct in future patches, but this basic stuff hasn't changed > > for some time. > > Thanks. I plan to revisit this after the .19 merge is done. > Currently there is too much noise in the tree and even your > tree seems to be still changing too quickly. > > The patch looks reasonable, except that you still have far too many > of these nasty __s around asm and volatile. Yes, the correct one I sent out later only has __ in two hunks (old code which I moved): I will go through later and remove them all as a separate patch if this annoys you. AFAICT, everything under #ifdef __KERNEL__ can be de-underscored without any ill effects. Thanks, Rusty. -- Help! Save Australia from the worst of the DMCA: http://linux.org.au/law
