On Thursday 10 August 2006 13:05, Rusty Russell wrote: > On Thu, 2006-08-10 at 12:30 +0200, Andi Kleen wrote: > > On Thu, Aug 10, 2006 at 08:10:03PM +1000, Rusty Russell wrote: > > > On Thu, 2006-08-10 at 19:35 +1000, Rusty Russell wrote: > > > > This version over last version: > > > > (1) Gets rid of the no_paravirt.h header and leaves native ops in place > > > > (with some reshuffling to keep then under one #ifdef). > > > > (2) Fixes the "X crashes with CONFIG_PARAVIRT=y" bug. > > > > (3) Puts __ex_table entry in paravirt iret. > > > > > > Gurp... that was old version. This version removes the explicit "save > > > flags and disable irqs" op (the binary patching patches it as one, but > > > there's little point having a short-cut through the slow path). > > > > Can you please do at least a s/__asm__/asm/g s/__volatile__/volatile/g ? > > > > And you seem to have added some __volatiles too, that should be also > > volatile. > > OK, here's with the __removal__ Hmm, i still see a lot of them (and __volatile too) Also maybe it's my mail client, but the resulting patch seems to be also full of MIME damage: EXTRA_AFLAGS :=3D -traditional Can you send it at least without that please? The __s I can fix up myself in the worst case if you don't want to. -Andi
