On Mon, Aug 07, 2006 at 10:53:28AM +0200, Andi Kleen wrote: > On Monday 07 August 2006 09:50, Rusty Russell wrote: > > On Mon, 2006-08-07 at 07:40 +0200, Andi Kleen wrote: > > > On Monday 07 August 2006 06:45, Rusty Russell wrote: > > > > Unfortunately, due to include cycles, we can't put these in > > > > paravirt.h: we use a separate header for these. > > > > > > > > The implementation comes from Zach's [RFC, PATCH 10/24] i386 Vmi descriptor changes: > > > > > > > > Descriptor and trap table cleanups. Add cleanly written accessors for > > > > IDT and GDT gates so the subarch may override them. Note that this > > > > allows the hypervisor to transparently tweak the DPL of the descriptors > > > > as well as the RPL of segments in those descriptors, with no unnecessary > > > > kernel code modification. It also allows the hypervisor implementation > > > > of the VMI to tweak the gates, allowing for custom exception frames or > > > > extra layers of indirection above the guest fault / IRQ handlers. > > > > > > Nice cleanup. The old assembly mess was ripe to be killed for a long time. > > > > OK, here's that patch extracted out. > > Is there something wrong with your mailer? This one doesn't apply either: Looks like it's against Linus' tree, not whatever you were trying against... (13:19:10:davej at nwo:linux-2.6)$ cat ~/rusty | patch -p1 --dry-run patching file arch/i386/kernel/traps.c Hunk #1 succeeded at 1116 (offset 4 lines). Hunk #3 succeeded at 1132 (offset 4 lines). patching file include/asm-i386/desc.h (13:19:15:davej at nwo:linux-2.6)$ Dave -- http://www.codemonkey.org.uk