[Xen-devel] Re: [PATCH 8 of 13] Add a bootparameter to reserve high linear address space for hypervisors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2006-08-02 at 06:21 +0200, Andi Kleen wrote:
> > 	I think you misunderstand the purpose of parse_early_param?  It is
> > designed to be called directly by the arch at some point (it is
> > idempotent, so the second call in init/main.c does nothing if the arch
> > has called it).  ie. in i386, it replaces parse_cmdline_early().
> 
> Ah I didn't realize that. But why is there a second call in init/main.c?  
> Looks like a big hack to me. Someone was too lazy to add it to all architectures?

Yes.  Someone == me.  I didn't want to hack it into all archs, I wanted
archs to actually use it, and you can see that's not a trivial patch...

Once all archs use it, we can probably clean up setup_arch() not to take
the char** and simply use the global saved_command_line directly.  At
this rate, that'll be around 2012 8)

Rusty.
-- 
Help! Save Australia from the worst of the DMCA: http://linux.org.au/law



[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux