On 25 Jul 2006, at 07:44, Gerd Hoffmann wrote: >> Actually, I think that it should be something like: >> #ifdef CONFIG_PARAVIRT >> #define __FIXADDR_TOP (paravirt_ops.fixaddr_top) >> #endif >> >> Then paravirt_ops.init will set this value in the paravirt_ops struct >> (just as it will set kernel_rpl). > > What is wrong with simply calling set_fixaddr_top() in > paravirt_ops.init? I don't see the point of moving that into the > paravirt_ops struct ... It makes sense to avoid this if there are other users of variable fixaddr_top. I generally prefer idea of the idea of poking values from paravirt init code rather than cluttering paravirt_ops with data fields. -- Keir
