* David Miller (davem at davemloft.net) wrote: > From: Chris Wright <chrisw at sous-sol.org> > Date: Tue, 18 Jul 2006 00:00:32 -0700 > > > +#ifdef CONFIG_XEN_BALLOON > > +#include <xen/balloon.h> > > +#endif > > Let's put the ifdefs in xen/balloon.h not in the files > including it. > > > +#ifdef CONFIG_XEN_BALLOON > > + /* Tell the ballon driver what is going on. */ > > + balloon_update_driver_allowance(i); > > +#endif > > Similarly let's define empty do-nothing functions in > xen/balloon.h when the config option isn't set so we > don't need to crap up the C sources with these ifdefs. Yeah, sorry it's kept more as a reminder to me. Upstream Xen doesn't do this, but this patchset doesn't support ballooning yet, so there just is not xen/balloon.h in the set. When merging with upstream Xen there's patch rejects either way, so I agree, better to just drop this since it's just future placeholder. thanks, -chris