On Tue, 18 Jul 2006 12:00:13 +0200 Arjan van de Ven <arjan at infradead.org> wrote: > On Tue, 2006-07-18 at 00:00 -0700, Chris Wright wrote: > > plain text document attachment (i386-mach-xen) > > Use arch/i386/mach-xen when building Xen subarch. The separate > > subarchitecture allows us to hide details of interfacing with the > > hypervisor from i386 common code. > > > Hi, > > please change the order of your patches next time, by sending the > makefile and config options first you'll break git bisect... > No, this patch is OK (in that respect). As long as the git-bisect user sets CONFIG_XEN=n (and surely he will), things will compile. That being said, +mflags-$(CONFIG_X86_XEN) := -Iinclude/asm-i386/mach-xen +mcore-$(CONFIG_X86_XEN) := mach-xen + # generic subarchitecture mflags-$(CONFIG_X86_GENERICARCH) := -Iinclude/asm-i386/mach-generic mcore-$(CONFIG_X86_GENERICARCH) := mach-default @@ -99,6 +103,7 @@ drivers-$(CONFIG_PM) += arch/i386/powe CFLAGS += $(mflags-y) AFLAGS += $(mflags-y) +CPPFLAGS += $(mflags-y) This change affects _all_ subarchitectures (by potentially altering their CPPFLAGS) and it's rather a mystery why one subarch needs the -Ifoo in its CPPFLAGS whereas all the others do not.
